PHP 8.3 build #1381
Merged
PHP 8.3 build #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
From my PoV, this is fine. Looking at RFCs in PHP 8.3, we don't have anything left either:
- Deprecations for PHP 8.3 (Created 2022-08-01)
- Path to Saner Increment/Decrement operators (Discussion started: 2023-01-17, Voting start: 2023-06-28, Voting end: 2023-07-12)
- Marking overridden methods (#[\Override]) (Created: 2023-05-06, Voting started: 2023-06-14)
- Arbitrary static variable initializers (Created 2022-11-06)
- Make unserialize() emit a warning for trailing data (Discussion started: 2023-03-27)
- Dynamic class constant fetch (Created 2022-11-04)
- Improve unserialize() error handling (Created 2022-09-01, Voting opened 2022-10-14, Voting closed 2022-10-28)
- Readonly amendments (Created 2022-10-24)
- Typed Class Constants (Discussion started: 2023-01-31, Voting started: 2023-02-27)
- Deprecate remains of string evaluated code assertions (Created: 2023-05-31, Voting start: 2023-06-28, Voting end: 2023-07-12)
- mb_str_pad (Created: 2023-05-19, Discussion started: 2023-05-20, Voting started: 2023-06-05, Voting closed: 2023-06-19)
- Saner array_(sum|product)() (Discussion started: 2023-01-17, Voting opened 2023-02-20, Voting closed 2023-03-06, Implemented: 2023-03-07)
- Define proper semantics for range() function (Discussion started: 2023-03-27, Voting started: 2023-06-01, Voting ended: 2023-06-15)
- Randomizer Additions (Created 2022-10-09)
- More Appropriate Date/Time Exceptions (Created 2022-11-29, Implemented: 2023-02-08)
- json_validate function (Created 2022-08-14, Voting closed: 2022-10-07)
- Use exceptions by default in SQLite3 extension
- Deprecate functions with overloaded signatures (Discussion started: 2023-04-27, Voting started: 2023-06-26, Voting ended: 2023-07-10)
We seem to already support typed class constants:
Once this is green, IMO 🚢
|
@ondrejmirtes has pointed me one more 8.3 feature php/php-src@79d024a |
kukulich
approved these changes
Nov 24, 2023
|
@michael-rubel can you lower the minimum mutation test core to make CI pass? I'm opening a separate issue to improve that again, meanwhile. |
|
@Ocramius Done. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Allows the usage in PHP 8.3.